Fix crash on shader constant initialization on MinGW compiler #93469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
shader_fix_crash
branch
3 times, most recently
from
74f0426
to
b59bceb
Compare
Chaosus
changed the title
Chaosus
force-pushed
the
shader_fix_crash
branch
from
b59bceb
to
d5b393a
Compare
Chaosus
changed the title
|
@matheusmdx would you like to check it? |
|
Cherry-picked on latest master and i can confirm this stop the crash |
akien-mga
approved these changes
Jun 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #93387 (only the crash, the constants parsing should be rewritten in future). As a workaround, it works.